Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Modified Dockerfile to be able to easily build and test. #623

Merged
merged 1 commit into from
Jul 21, 2022
Merged

test: Modified Dockerfile to be able to easily build and test. #623

merged 1 commit into from
Jul 21, 2022

Conversation

marcusber
Copy link
Contributor

Fixes

Enables docker to be used to build and test the code.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
    • Tests passes using the instruction in the readme.
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified
    • No code modifled.

@marcusber marcusber mentioned this pull request Jul 21, 2022
Closed
8 tasks
childish-sambino
childish-sambino approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Testing internal tooling for any issues ... and will then merge.

@childish-sambino childish-sambino changed the title chore: Modified Dockerfile to be able to easily build and test. test: Modified Dockerfile to be able to easily build and test. Jul 21, 2022
@childish-sambino childish-sambino merged commit 2b60ead into twilio:main Jul 21, 2022
Swimburger pushed a commit to Swimburger/twilio-csharp that referenced this pull request Dec 28, 2022
@marcusber @Swimburger
test: Modified Dockerfile to be able to easily build and test (twilio…
3daecd1 
…#623)

Enables docker to be used to build and test the code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusber @childish-sambino