Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update method comments to reflect new security testing method #705

Merged
merged 4 commits into from
Oct 3, 2023
Merged

fix: Update method comments to reflect new security testing method #705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e661477
Changes in validate ssl certificate method with new url and port
AsabuHere Sep 22, 2023
acfe2ae
Modifying test case to change validation error comparison
AsabuHere Sep 22, 2023
58c9b51
Comments updated with new security method for ssl certificates
AsabuHere Oct 3, 2023
d44c986
Merge branch 'main' into validate_ssl_update
AsabuHere Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Twilio/Clients/TwilioRestClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,9 @@ private static Response ProcessResponse(Response response)
}

/// <summary>
/// Test that this application can use updated SSL certificates on
/// api.twilio.com:8443. It's a bit easier to call this method from
/// TwilioClient.ValidateSslCertificate().
/// Test if your environment is impacted by a TLS or certificate change
/// by sending an HTTP request to the test endpoint tls-test.twilio.com:443
/// It's a bit easier to call this method from TwilioClient.ValidateSslCertificate().
/// </summary>
public static void ValidateSslCertificate()
{
Expand Down
4 changes: 2 additions & 2 deletions src/Twilio/Twilio.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ public static void Invalidate()
}

/// <summary>
/// Validates that the Twilio Client can connect to api.twilio.com with
/// a new SSL certificate posted at api.twilio.com:8443
/// Test if your environment is impacted by a TLS or certificate change
/// by sending an HTTP request to the test endpoint tls-test.twilio.com:443
/// </summary>
public static void ValidateSslCertificate()
{
Expand Down
Loading