Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Cancellation Token #772

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Added Cancellation Token #772

wants to merge 8 commits into from

Conversation

joewashear007
Copy link

@joewashear007 joewashear007 commented Jan 13, 2025 •
edited
Loading

Fixes

Fixes #514
This PR added the CancellationToken to all the async endpoints and all of the pass throughs

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@joewashear007 joewashear007 changed the title Added Cancellation Token feat: Added Cancellation Token Jan 13, 2025
@joewashear007 joewashear007 mentioned this pull request Jan 13, 2025
Open
@joewashear007 joewashear007 marked this pull request as ready for review January 13, 2025 14:36
@joewashear007 joewashear007 marked this pull request as draft January 13, 2025 15:20
@joewashear007 joewashear007 marked this pull request as ready for review January 15, 2025 18:56
@joewashear007
Copy link
Author

I think this PR is ready, though I think it need to be reworked. it touches many of the auto generated files. But I don't think I can edit the auto generator to add the CancellationToken to the Async methods

@sbansla
Copy link
Contributor

sbansla commented Jan 16, 2025 •
edited
Loading

We are planning to change Orgs API RestClient.
We will review this change at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Add CancellationToken pass-through to async request methods
2 participants
@joewashear007 @sbansla