Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Initializing go helper library with auto generated code #37

Merged
merged 22 commits into from
Jan 28, 2021
Merged

feat: Initializing go helper library with auto generated code #37

merged 22 commits into from
Jan 28, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

@shwetha-manvinkurke shwetha-manvinkurke commented Jan 15, 2021 •
edited
Loading

Initializing with auto generated code

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Related PR: twilio/twilio-oai-generator#1

@shwetha-manvinkurke shwetha-manvinkurke mentioned this pull request Jan 15, 2021
Merged
6 tasks
@eshanholtz
Copy link
Contributor

Build check shouldn't be failing, can you check out the errors?

@shwetha-manvinkurke
Copy link
Contributor Author

Some basic tests run

@thinkingserious
Copy link
Contributor

Go tests generally end in _test.go.

thinkingserious
thinkingserious approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@thinkingserious thinkingserious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@shwetha-manvinkurke shwetha-manvinkurke merged commit 738271f into main Jan 28, 2021
@shwetha-manvinkurke shwetha-manvinkurke deleted the DI_968 branch January 28, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz left review comments

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shwetha-manvinkurke @eshanholtz @thinkingserious