fix: implement map line_type_intelligence snake_case fields to camelCase in constructor for PhoneNumberInstance #1149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1148
Description
This PR fixes a bug where
line_type_intelligencefields returned from the Lookups API (insnake_case) were not mapped to the camelCase properties expected by thePhoneNumberInstanceclass.Breaking Change:
This change creates a new object for
lineTypeIntelligencerather than assigning the raw payload.mobile_country_code) at runtime, while the TypeScript definitions existed for camelCase (e.g.,mobileCountryCode) but returnedundefined.What was changed
PhoneNumberInstanceconstructor to manually mapline_type_intelligenceproperties:mobile_country_code→mobileCountryCodemobile_network_code→mobileNetworkCodecarrier_name→carrierNametype→typeerror_code→errorCodeLineTypeIntelligenceInfointerface.Why the change was necessary
The
PhoneNumberInstancewas assigning the raw API response directly to the class property, causing a mismatch between the TypeScript definitions (camelCase) and the runtime values (snake_case). This resulted inundefinedvalues when using the typed properties.Checklist