Check X-Twilio-Signature in webhook middleware #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to check if the X-Twilio-Signature header exists or not
childish-sambino
approved these changes
May 14, 2019
|
@neerajwadhwa, @childish-sambino I was wondering, why this check is added here before checking the validate option. I am sending requests from POSTMAN and I have not set X-Twilio-Signature. I am on dev/test environment, which means the validate option is false, so there is no need to check if the header is present or not. Similarly, if I write a test for Express route in my code, the middleware will fail despite the fact that validate option is false. |
|
@neerajwadhwa It also checks for X-Twilio-Signature here which will not fail with validate set to false. |
|
@khalilchoudhry The changes mentioned were made in very close time proximity so the coordination wasn't perfect. Will follow-up on #460 |
ghost
mentioned this pull request
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a check in lib/webhooks/webhooks.js's webhook() middleware to check if the X-Twilio-Signature header exists or not.
If the request is not made from Twilio servers then we won't have X-Twilio-Signature header in the request and the middleware will throw cryptic error from validateRequest() function.