-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Rewrite hand-crafted JS files into TS files #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined Page._solution as a map<any> type and fixed SDK lib import statement in example.ts
Updated RequestClient SSL CA tests due to the original implementation not correctly adhering to the Axios library API.
Some of the tests will still fail for the following reasons:
|
This was referenced Dec 9, 2022
Changes should be merged alongside the removal of the Page namespace references in the generated code (namespace no longer exists). Link to PR: #841 (merged) |
mattcole19
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
reviewed
Dec 14, 2022
claudiachua
approved these changes
Dec 14, 2022
Improved TS type annotations for optional and required parameters and undefined return values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts hand-crafted JS files into TS files and removes the accompanying *.d.ts declaration files.
Notable Changes:
https.Agent
agent options used bythis.axios.defaults.httpsAgent
"should cache the CA after loading it for the first time"
test. Current implementation doesn't allow the custom ahttps.Agent
to be created at request execution with the current CA bundle for the Axios instance to use (ref: DI-2477)Internal ref: DI-1418