fix: update SMS messaging parse error

lib/base/RestException.ts

@@ -1,6 +1,13 @@
 "use strict";
+interface RestExceptionError {
+  status: number;
+  message: string;
+  code: number;
+  moreInfo: string;
+  details: object;
+}
 
-export default class RestException extends Error {
+export default class RestException extends Error implements RestExceptionError {
   status: number;
   message: string;
   code: number;
@@ -9,15 +16,28 @@ export default class RestException extends Error {
 
   constructor(response) {
     super("[HTTP " + response.statusCode + "] Failed to execute request");
+    const isResponseBodyString = typeof response.body == "string";
+    const body = isResponseBodyString
+      ? parseResponseBody(response.body)
+      : response.body;
 
-    const body =
-      typeof response.body === "string"
-        ? JSON.parse(response.body)
-        : response.body;
     this.status = response.statusCode;
-    this.message = body.message;
-    this.code = body.code;
-    this.moreInfo = body.more_info; /* jshint ignore:line */
-    this.details = body.details;
+    if (body !== null) {
+      this.message = body.message;
+      this.code = body.code;
+      this.moreInfo = body.more_info; /* jshint ignore:line */
+      this.details = body.details;
+    }
   }
 }
+
+function parseResponseBody(response_body: string): RestExceptionError | null {
+  let body = null;
+  try {
+    body = JSON.parse(response_body);
+  } catch (catchError) {
+    body = null;
+  }
+
+  return body;
+}

spec/unit/base/RestException.spec.js → spec/unit/base/RestException.spec.ts

@@ -6,6 +6,7 @@ describe("exception gets created from string", function () {
       statusCode: 200,
       body: '{"message":"test", "code":81022,"more_info": "https://www.twilio.com/docs/errors/81022"}',
     };
+
     const exception = new RestException(response);
     expect(exception.status).toEqual(200);
     expect(exception.message).toEqual("test");
@@ -14,6 +15,19 @@ describe("exception gets created from string", function () {
       "https://www.twilio.com/docs/errors/81022"
     );
   });
+  it("should test serialize from improper json string", function () {
+    const response = {
+      statusCode: 200,
+      body: '{message":test", "code:81022,"more_info": "https://www.twilio.com/docs/errors/81022"}',
+    };
+    const exception = new RestException(response);
+    expect(exception.status).toEqual(200);
+    expect(exception.message).toEqual(
+      `[HTTP ${response.statusCode}] Failed to execute request`
+    );
+    expect(exception.code).toEqual(undefined);
+    expect(exception.moreInfo).toEqual(undefined);
+  });
 });
 
 describe("exception gets created from json error", function () {