test: refactor cluster tests for pack output #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Hunga1
approved these changes
Feb 21, 2023
rakatyal
reviewed
Feb 21, 2023
| @@ -64,8 +63,6 @@ | |||
| "nsp": "npm audit --production", | |||
| "prettier": "prettier --write .", | |||
| "prettier-check": "prettier --check .", | |||
| "cluster": "jest ./cluster_test.spec.ts --coverage", | |||
There was a problem hiding this comment.
Should we have a command to run cluster test locally without npm packaging?
There was a problem hiding this comment.
I think it would be nice, but it requires either duplicating the cluster test file or scripting changing the import(s).
rakatyal
approved these changes
Feb 21, 2023
|
Looks good! Please link the JIRA ticket in the description too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DI-2566