chore: clean up prism mocker #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
eshanholtz
reviewed
Apr 30, 2021
| @@ -3,6 +3,7 @@ | |||
| OPENAPI_GENERATOR_VERSION=5.0.1 | |||
|
|
|||
| install: | |||
| cd examples/go && go get github.com/twilio/twilio-go@main | |||
There was a problem hiding this comment.
Not something to fix right now, but don't like that we're requiring go during install since we may use this repo to generate other languages in the future.
There was a problem hiding this comment.
Agreed. The goal here is to pull the latest commit from twilio-go when running tests. Would it be better to move this into the ./prism.sh file?
There was a problem hiding this comment.
I'm okay with it here for now since it makes working with the Go tests in an IDE better.
childish-sambino
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Remove duplicate files and use the code in twilio-go. Add documentation for how to run tests locally.
Jira Ticket: https://issues.corp.twilio.com/browse/DI-1263
Related PR: #34
Checklist
make test-docker