Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor node to use the resource builder #373

Merged
merged 2 commits into from
Dec 27, 2022
Merged

chore: refactor node to use the resource builder #373

merged 2 commits into from
Dec 27, 2022

Conversation

childish-sambino
Copy link
Contributor

Also synchronizes the config file.

twilio/twilio-node#843

Sam Harrison added 2 commits December 16, 2022 12:39
@sonarqubecloud
Copy link

[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@childish-sambino childish-sambino mentioned this pull request Dec 16, 2022
Merged
claudiachua
claudiachua reviewed Dec 27, 2022
View reviewed changes
src/main/resources/config/node.json
@@ -1,7 +1,7 @@
{
"library": {
"phone_number_capabilities": {
"PhoneNumberCapabilities": "interfaces"
"PhoneNumberCapabilities": "lib/interfaces"
Copy link
Contributor

@claudiachua claudiachua Dec 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have to add lib/? Since PhoneNumberCapabilities are only used by files within lib folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just synching with the actual file here which includes the lib path: https://github.com/twilio/twilio-oai/blob/main/types/node.json

@childish-sambino childish-sambino merged commit 2529bc7 into main Dec 27, 2022
@childish-sambino childish-sambino deleted the node-builder-refactor branch December 27, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiachua claudiachua claudiachua left review comments

@beebzz beebzz beebzz approved these changes

@rakatyal rakatyal rakatyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@childish-sambino @rakatyal @beebzz @claudiachua