Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Json request body added for csharp #524

Merged
merged 9 commits into from
Sep 20, 2023
Merged

fix: Json request body added for csharp #524

merged 9 commits into from
Sep 20, 2023

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

  • Added GetBody() in Options file
  • Added request body and contentType support in mustache files

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

sbansla
sbansla requested changes Sep 19, 2023
View reviewed changes
src/main/resources/twilio-csharp/options/CreateOptions.mustache
@@ -19,6 +19,11 @@
}
{{/vendorExtensions.x-required-param-exists}}

{{^vendorExtensions.x-is-json}}
{{>options/GetParams}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are failing because, GetParams is commented in ReadOptions but there is ovveride keyword in
https://github.com/twilio/twilio-csharp/blob/main/src/Twilio/Rest/Accounts/V1/Credential/AwsOptions.cs#L138

  1. Remove override using twilio-oai-generator
  2. Generate C# code using twilio-oai-generator and create a PR with main branch. Make sure there are no other changes then override removal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a PR for above mentioned:
twilio/twilio-csharp#699
You can review that and merge after reviewing.

sbansla
sbansla requested changes Sep 20, 2023
View reviewed changes
src/main/resources/twilio-csharp/resource/CreateResource.mustache Outdated
{{#bodyParam}}
contentType: EnumConstants.ContentTypeEnum.JSON,
body: options.GetBody(),
{{/bodyParam}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in file CreateOptions.mustache
We are compariing using vendorExtension if request body has json or not. Here we are comparing with different variable.
Lets use only one way to compare.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change correct?

@sonarqubecloud
Copy link

[twilio-oai-generator-php] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-ruby] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-java] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-python] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-node] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[twilio-oai-generator-go] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sbansla
sbansla approved these changes Sep 20, 2023
View reviewed changes
src/main/resources/twilio-csharp/resource/CreateResource.mustache
contentType: EnumConstants.ContentTypeEnum.JSON,
body: options.GetBody(),
{{/bodyParam}}
{{/vendorExtensions.x-is-json}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbansla sbansla merged commit d19b74e into main Sep 20, 2023
@sbansla sbansla deleted the csharp-request-body branch September 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla sbansla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiwarishubham635 @sbansla