Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added boolean_to_string converter for python #554

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

tiwarishubham635
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 commented Feb 2, 2024

Fixes

In Python, booleans are True and False (instead of true and false in other languages). Due to this, while creating request body, the booleans are getting passed as 'True' to the API downstream, while it is expecting 'true'. So this fix adds a boolean_to_string converter for python which passes the expected boolean string to API downstreams.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-python and inspect the diff
    • Run make test in twilio-python
    • Create a pull request in twilio-python
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-java'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-php'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-ruby'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-node'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
40.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-go'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tiwarishubham635
Copy link
Contributor Author

Here is the twilio-python PR with changes

@tiwarishubham635 tiwarishubham635 merged commit ab83933 into main Feb 22, 2024
22 checks passed
@tiwarishubham635 tiwarishubham635 deleted the boolean_to_string branch February 22, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants