Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read version and domain from path instead of filename for go #562

Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix: read version and domain from path instead of filename for go #562

merged 3 commits into from
Mar 12, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Fetch version from open api spec paths instead of file name.
A breaking change for go.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@tiwarishubham635 tiwarishubham635 requested a review from sbansla March 8, 2024 11:21
sbansla
sbansla reviewed Mar 12, 2024
View reviewed changes
src/main/java/com/twilio/oai/AbstractTwilioGoGenerator.java
@@ -78,6 +78,15 @@ public void processOpenAPI(final OpenAPI openAPI) {
param.addExtension(ACCOUNT_SID_VEND_EXT, true);
});

String domain = StringHelper.toSnakeCase(twilioCodegen.getDomainFromOpenAPI(openAPI));
int lastIndex = domain.lastIndexOf("_api");
Copy link
Contributor

@sbansla sbansla Mar 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here that we are skipping _api for backward compatibility of folder names.
Give example that frontline-api server won't be converted to frontline_api folder name but frontline for backward compatibility.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

sbansla
sbansla requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@sbansla sbansla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here that we are skipping _api for backward compatibility of folder names.
Give example that frontline-api server won't be converted to frontline_api folder name but frontline for backward compatibility.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-java'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-php'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-ruby'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-node'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tiwarishubham635 tiwarishubham635 merged commit c0c8fa6 into main Mar 12, 2024
22 checks passed
@tiwarishubham635 tiwarishubham635 deleted the go_domain_fix branch March 12, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbansla sbansla sbansla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiwarishubham635 @sbansla