Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore content_v1 spec for release and iam_organizations spec file as versionless #606

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Aug 22, 2024

Fixes

  1. Temporary Fix for Content API Team:
    All contents of content_v1 has been moved to content_sdk spec file.
    Thus ignoring content_v1

  2. Made twilio_iam_organizations spec file as versionless
    Corresponding twilio-java PR
    fix: making previewiam versionless twilio-java#811

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@sbansla sbansla changed the title chore: ignore content_v1 spec for release chore: ignore content_v1 spec for release and iam_organizations spec file as versionless Aug 22, 2024
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'twilio-oai-generator-java'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

@tiwarishubham635 tiwarishubham635 merged commit d123b38 into main Aug 23, 2024
18 of 21 checks passed
@tiwarishubham635 tiwarishubham635 deleted the ignore-content-v1 branch August 23, 2024 11:37
AsabuHere pushed a commit that referenced this pull request Sep 20, 2024
AsabuHere pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants