Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint on PhoneNumberInstance.carrier should be dict instead of unicode #451

Closed
sauravc opened this issue Dec 28, 2018 · 1 comment · Fixed by #481 or #482
Closed

Type hint on PhoneNumberInstance.carrier should be dict instead of unicode #451

sauravc opened this issue Dec 28, 2018 · 1 comment · Fixed by #481 or #482
Labels
code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: bug bug in the library

Comments

@sauravc
Copy link

sauravc commented Dec 28, 2018

The type hint on the carrier property incorrectly marks it as unicode instead of dict here: https://github.com/twilio/twilio-python/blob/6.21.0/twilio/rest/lookups/v1/phone_number.py#L244

Version:
6.21

Code Snippet

>>> p = client.lookups.phone_numbers('+12063211234').fetch(type='carrier')
>>> type(p.carrier)  # Type hint of unicode is incorrect: https://github.com/twilio/twilio-python/blob/6.21.0/twilio/rest/lookups/v1/phone_number.py#L244
<class 'dict'>

Steps to Reproduce

  1. Use Twilio Python SDK to do a Lookup API call on a phone number
  2. See the type of the carrier property of the resulting PhoneNumberInstance. It is not unicode, but a dict instead.
@childish-sambino childish-sambino added code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: bug bug in the library labels Sep 17, 2019
@childish-sambino
Copy link
Contributor

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-generation issue deals with generated code difficulty: easy fix is easy in difficulty type: bug bug in the library
Projects
None yet
2 participants