Change typehint for PhoneNumberInstance.carrier
#481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is in a generated file so changes will be overwritten on the next release. Changes are needed in the internal generator to resolve the issue. Leaving open for reference. |
childish-sambino
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
#482 submitted which is a result of the internal generator updates. Approving and merging this one so you'll get credit in the upcoming changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #451, where the typehint for
PhoneNumberInstance.carrierwas wrong.Contributing to Twilio