Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding timeout to TwilioHttpClient constructor #485

Merged
merged 4 commits into from
Oct 24, 2019
Merged

Adding timeout to TwilioHttpClient constructor #485

merged 4 commits into from
Oct 24, 2019

Conversation

Kerl1310
Copy link
Contributor

Fixes #460 - Adds a timeout parameter to the TwilioHttpClient constructor which is defaulted to None

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@Kerl1310 Kerl1310 mentioned this pull request Oct 15, 2019
Closed
@childish-sambino
Copy link
Contributor

Thanks for the PR @Kerl1310! Could you add tests to test_http_client.py to validate the new behavior?

@childish-sambino childish-sambino added the status: work in progress Twilio or the community is in the process of implementing label Oct 15, 2019
@Kerl1310
Copy link
Contributor Author

Sure, shall update shortly

@Kerl1310
Copy link
Contributor Author

Okay so going forward I'll add some unit tests for the different scenarios we've talked about and add a check for if the value is set to <= 0 so that we don't get any ValueException issues from urllib3

@Kerl1310
Copy link
Contributor Author

@childish-sambino New commit added with some unit tests covering what would happen in the given scenarios, could you review please?

childish-sambino
childish-sambino approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Oct 23, 2019
@eshanholtz eshanholtz merged commit 53511c1 into twilio:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eshanholtz eshanholtz eshanholtz left review comments

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TwilioHttpClient does not support timeout in constructor
3 participants
@Kerl1310 @childish-sambino @eshanholtz