Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Added faraday adapter_options #713

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

ollym
Copy link

@ollym ollym commented Feb 27, 2024

Fixes

This PR adds adapter options to faraday, example usage can be seen here:
https://github.com/lostisland/faraday/blob/main/lib/faraday/rack_builder.rb#L75

We use a custom adapter that adds adapter options for logging which is important for us.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@ollym ollym changed the title Added faraday adapter_options misc: Added faraday adapter_options Feb 27, 2024
@ollym
Copy link
Author

ollym commented Apr 1, 2024

🙏 can someone take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant