Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oauth ruby #733

Merged
merged 22 commits into from
Nov 26, 2024
Merged

feat: oauth ruby #733

merged 22 commits into from
Nov 26, 2024

Conversation

manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Nov 12, 2024 •
edited
Loading

Feature

Adds Oauth support for Ruby

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997 manisha1997 marked this pull request as draft November 12, 2024 11:22
@manisha1997 manisha1997 marked this pull request as ready for review November 13, 2024 06:52
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@manisha1997 manisha1997 changed the base branch from main to public-oauth November 20, 2024 06:51
@AsabuHere
Copy link
Contributor

Add a new credential provider for public oauth token fetching. In future there can be two different endpoints for fetching tokens for organization domains and other domains

@manisha1997
Copy link
Contributor Author

Add a new credential provider for public oauth token fetching. In future there can be two different endpoints for fetching tokens for organization domains and other domains

Can you please elaborate here?

AsabuHere
AsabuHere approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manisha1997 manisha1997 merged commit e4e5199 into public-oauth Nov 26, 2024
14 of 15 checks passed
@manisha1997 manisha1997 deleted the oauth-ruby branch November 26, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsabuHere AsabuHere AsabuHere approved these changes

@tiwarishubham635 tiwarishubham635 Awaiting requested review from tiwarishubham635

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manisha1997 @AsabuHere