Fix camera light bug

[timmydoza]

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

• I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

• N/A

Description

This PR fixes a bug where Video.createLocalTracks() was being called more than once. Now, Video.createLocalTracks() will not be called when isAcquiringTracks is true, which stops the extra calls to createLocalTracks.

This was causing an issue where the camera light would not turn off when the video was muted. This is because the extra call to Video.createLocalTracks() would create MediaStreams that were ignored and never stopped by the app when the user muted their video. The browser requires that all instances of a MediaStream be stopped before the camera light is turned off.

Burndown

Before review

• Updated CHANGELOG.md if necessary
• Added unit tests if necessary
• Updated affected documentation
• Verified locally with npm test
• Manually sanity tested running locally
• Included screenshot as PR comment (if needed)
• Ready for review

Before merge

• Got one or more +1s
• Re-tested if necessary