Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade twilio-video to 2.11.0 #409

Merged
merged 2 commits into from
Feb 2, 2021
Merged

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented Jan 29, 2021

Remove @types/twilio-video
Update types.ts file

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This PR upgrades twilio-video.js to version 2.11.0. It also removes the @types/twilio-video type definitions as type definitions for twilio-video are now included starting in version 2.11.0.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

Remove @types/twilio-video
Update types.ts file
setPriority: (priority: Track.Priority) => void;
}

// These help to create union types between Local and Remote VideoTracks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this in the sdk that way we can get rid of this declaration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I'm leaning towards no. This declaration is added because we are creating a union type with LocalVideoTracks and RemoteVideoTracks. Not every application developer may want to do this, so I don't think it needs to be added to the SDK. We aren't adding it here because of a flaw in the SDK types.

Plus, it isn't taking much space here in types.js. I'm not in a hurry to get rid of it 🙂

@timmydoza timmydoza merged commit 8b9230c into master Feb 2, 2021
@timmydoza timmydoza deleted the upgrade-twilio-video-to-2-11-0 branch February 2, 2021 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants