Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary deps #527

Merged
merged 5 commits into from
May 24, 2021
Merged

Remove unnecessary deps #527

merged 5 commits into from
May 24, 2021

Conversation

timmydoza
Copy link
Contributor

@timmydoza timmydoza commented May 24, 2021

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

  • N/A

Description

This pull request removes some unnecessary dependencies from some react hooks. It was originally submitted by @hahnlee in PR #393.

I closed #393 so that our CircleCI tests will run, and we can merge the PR.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza changed the base branch from master to AHOYAPPS-619-select-stage May 24, 2021 19:23
@timmydoza timmydoza changed the base branch from AHOYAPPS-619-select-stage to master May 24, 2021 19:23
@timmydoza timmydoza requested a review from olipyskoty May 24, 2021 19:35
olipyskoty
olipyskoty previously approved these changes May 24, 2021
@timmydoza timmydoza merged commit 1f5b2fa into master May 24, 2021
@timmydoza timmydoza deleted the fix/deps branch May 24, 2021 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants