Skip to content

Conversation

@timmydoza
Copy link
Contributor

@timmydoza timmydoza commented May 26, 2022

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds some logic to the app which switches the user to the Collaboration View when a remote participant (but not the local participant) starts to share their screen. Without this, a user using Grid View would not know that someone else is sharing their screen. Once the user has been automatically switched over to Grid View, they are free to switch back to Collaboration View.

This is the same behavior as what is already implemented in the iOS Video App: https://github.com/twilio/twilio-video-app-ios/blob/67b8494a50eb48568b966aa9cf4c5dea2d327e61/VideoApp/VideoApp/SwiftUI/Screens/Room/RoomViewModel.swift#L88-L118

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Included screenshot as PR comment (if needed)
  • Ready for review

Before merge

  • Got one or more +1s
  • Re-tested if necessary

@timmydoza timmydoza requested a review from charliesantos May 27, 2022 22:57
@timmydoza timmydoza merged commit 9dab5ba into feature/grid-mode Jun 1, 2022
@timmydoza timmydoza deleted the VIDEO-10095-handle-screenshare-in-grid-mode branch June 1, 2022 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants