[VBLOCKS-1715] feat: outgoing call test #64

kpchoy · 2023-05-31T16:43:43Z

Submission Checklist

The CHANGELOG.md reflects any feature, bug fixes, or known issues made in the source code
New unit tests and integration tests have beed added
Code coverage is more or equal to the previous coverage
A visual inspection of the Files changed tab was made prior to submitting the pull request ensuring the style guide was followed
CI pipeline is green
Included screenshot if necessary

Description

VBLOCKS-1715

Breakdown

outgoing call UI test
success case (android only)
disconnect cases

Validation

[Bulleted summary of validation steps including local and CI pipeline]
[eg. Added new test]
[eg. Manually tested with both app and server]

Additional Notes

[Any additional comments, notes, or information relevant to reviewers.]

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

I acknowledge that all my contributions will be made under the project's license.

charliesantos

Left some comments. We should also add tests that covers the following:

check if call is disconnected after clicking end button
check if call is disconnected after callee disconnects the call or times out
Since this is a timebox task, this can be part of next sprint (new ticket) if you run out of time this sprint.

CHANGELOG.md

app/e2e/outgoingcall.test.js

charliesantos · 2023-06-01T17:51:41Z

app/e2e/outgoingcall.test.js

+ await element(by.id('call_button')).tap();
+ await waitFor(element(by.id('active_call'))).toBeVisible();
+ await waitFor(element(by.id('call_status'))).toHaveText('ringing');
+ await waitFor(element(by.id('call_status'))).toHaveText('disconnected');


Can you also check that the call gets disconnected right away? It should get disconnected in less than 3s, is that correct?

I don't think it can be right away, since the UI still needs time to switch Views. That is why I used a waitFor, since without it the test fails. Where does the 3s come from?

By "right away" I mean, it should not feel like it's stuck. 3s is just an estimate. What we want is, we need to fail this test if it exceeds a certain threshold. For example, if it does not disconnect after 20s, there must be something wrong. 20s is too extreme, so I estimated around 3s. How long do you think we should wait before we consider this as a fail?

I get what you mean now. Okay will add another testcase. 3s sounds like a good time to me 👍

charliesantos · 2023-06-01T17:52:08Z

app/e2e/outgoingcall.test.js

+ await waitFor(element(by.id('active_call'))).not.toBeVisible();
+ });
+
+ it('should disconnect if invalid Client-ID', async () => {


Same here, we should check that the call has been disconnected right away.

Disconnect still doesn't happen right away. We still have the user see texts ringinging -> disconnect -> back to dial screen.

Same as my response here #64 (comment)

charliesantos

Left some comments. We should also add tests that covers the following:

check if call is disconnected after clicking end button
check if call is disconnected after callee disconnects the call or times out
Since this is a timebox task, this can be part of next sprint (new ticket) if you run out of time this sprint.

kpchoy · 2023-06-01T18:55:04Z

check if call is disconnected after clicking end button

I tried to do test case disconnect after clicking end button , but the test would always fail. I believe this a detox issue, and the issue is still open wix/Detox#1185

No views in hierarchy found matching: (with tag value: is "<Test ID>" and view has effective visibility=VISIBLE

kpchoy · 2023-06-01T18:55:53Z

check if call is disconnected after callee disconnects the call or times out

Can setup another number and use Twilio verb to end

charliesantos · 2023-06-01T21:06:28Z

app/e2e/outgoingcall.test.js

@@ -0,0 +1,82 @@
+import { by, element, expect, waitFor, device } from 'detox';
+
+describe('Outgoing Call', () => {


Let's continue the discussion here regarding the following test case, so we can separate the thread

check if call is disconnected after clicking end button

I tried to do test case disconnect after clicking end button , but the test would always fail. I believe this a detox issue, and the issue is still open wix/Detox#1185

Clicking the end button behaves the same as when the call is disconnected correct? Can we assert that the active call screen is not visible anymore and that it will transition to the next screen?

I had tried various methods earlier in the week, so I didn't think this was possible. But I tried a few more methods yesterday and today, now I have one that works. I have now included a test for your test case.

charliesantos · 2023-06-01T21:08:31Z

app/e2e/outgoingcall.test.js

@@ -0,0 +1,82 @@
+import { by, element, expect, waitFor, device } from 'detox';
+
+describe('Outgoing Call', () => {


Let's continue the discussion here regarding the following test case, so we can separate the thread

check if call is disconnected after callee disconnects the call or times out

Can setup another number and use Twilio verb to end

I don't think we need to. We can just wait until the current call times out? It's only 10s long right?

Yes call is only 10s. Ok will add a 12s timer to make sure call is no longer in progress

…-react-native-app into feat-call-ui-testing

charliesantos

Nice! I'm glad we're able to cover all the cases we talked about. +1 for me.
I also left a couple of questions. You can merge the PR after answering.

charliesantos · 2023-06-02T18:54:22Z

app/e2e/outgoingCall.test.js

+ await element(by.id('dialpad_button_5')).tap();
+ await element(by.id('dialpad_button_4')).tap();
+ await element(by.id('dialpad_button_1')).tap();
+ await device.disableSynchronization();


What does this do?

Detox tries to optimize by "synchronizing" https://wix.github.io/Detox/docs/troubleshooting/synchronization/ . But I think there is some kind of bug triggered by their optimization when trying to click the "end call" button. When in the normal "synchronizing" mode detox cannot find the "end call" button, even though I see it as detox steps through the test case. I found a stackoverflow where someone recommended disabling this "testing opimization" https://stackoverflow.com/questions/59412749/detox-detect-that-element-was-displayed

charliesantos · 2023-06-02T18:54:33Z

app/e2e/outgoingCall.test.js

+ .toExist()
+ .withTimeout(3000);
+ await element(by.id('end_call_button')).tap();
+ await device.enableSynchronization();


What does this do?

same as above ^

feat: outgoing call test

ba4b370

kpchoy changed the title ~~feat: outgoing call test~~ [VBLOCKS-1715] feat: outgoing call test May 31, 2023

kpchoy added 4 commits May 31, 2023 12:29

refactor: test and disconnect case for duration timer

02a0cb3

refactor: remove end call test

ac4b46c

refactor: add waitFor in disconnect; changelog

62c1d89

chore: call cases only for android

530fb38

kpchoy requested a review from charliesantos June 1, 2023 00:03

charliesantos requested changes Jun 1, 2023

View reviewed changes

chore: change log

7e35563

kpchoy requested a review from charliesantos June 1, 2023 18:58

charliesantos reviewed Jun 1, 2023

View reviewed changes

kpchoy and others added 4 commits June 1, 2023 16:52

feat: add disconnect cases to e2e

42508f2

Duplicate file

d4a9a8e

refactor: disable sync for test

26cd3c0

Merge branch 'feat-call-ui-testing' of github.com:twilio/twilio-voice…

577b789

…-react-native-app into feat-call-ui-testing

kpchoy requested a review from charliesantos June 2, 2023 18:51

charliesantos approved these changes Jun 2, 2023

View reviewed changes

kpchoy merged commit 21543f3 into main Jun 2, 2023

kpchoy deleted the feat-call-ui-testing branch June 2, 2023 19:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VBLOCKS-1715] feat: outgoing call test #64

[VBLOCKS-1715] feat: outgoing call test #64

kpchoy commented May 31, 2023 •

edited

Loading

charliesantos left a comment

charliesantos Jun 1, 2023

kpchoy Jun 1, 2023

charliesantos Jun 1, 2023

kpchoy Jun 1, 2023

charliesantos Jun 1, 2023

kpchoy Jun 1, 2023

charliesantos Jun 1, 2023

charliesantos left a comment

kpchoy commented Jun 1, 2023

kpchoy commented Jun 1, 2023

charliesantos Jun 1, 2023

kpchoy Jun 2, 2023

charliesantos Jun 1, 2023

kpchoy Jun 1, 2023

charliesantos left a comment

charliesantos Jun 2, 2023

kpchoy Jun 2, 2023

charliesantos Jun 2, 2023

kpchoy Jun 2, 2023

		@@ -0,0 +1,82 @@
		import { by, element, expect, waitFor, device } from 'detox';

		describe('Outgoing Call', () => {

[VBLOCKS-1715] feat: outgoing call test #64

[VBLOCKS-1715] feat: outgoing call test #64

Conversation

kpchoy commented May 31, 2023 • edited Loading

Submission Checklist

Description

Breakdown

Validation

Additional Notes

charliesantos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charliesantos left a comment

Choose a reason for hiding this comment

kpchoy commented Jun 1, 2023

kpchoy commented Jun 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

charliesantos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpchoy commented May 31, 2023 •

edited

Loading