Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Modernize the code? #72

Closed
rationalthinker1 opened this issue Feb 2, 2022 · 9 comments
Closed

[FEATURE] Modernize the code? #72

rationalthinker1 opened this issue Feb 2, 2022 · 9 comments
Assignees
Labels

Comments

@rationalthinker1
Copy link

Is your feature request related to a problem? Please describe.
Yes, I cannot use Vite because the code is not updated

Describe the solution you'd like
a modernize codebase, with import, async, replacing xmlhttprequest with fetch etc...

@rationalthinker1 rationalthinker1 added the enhancement New feature or request label Feb 2, 2022
@aaroncsolomon
Copy link

Bump here^ - there are numerous issues across the codebase ranging from incompatibility with Node 16 to lack of polyfill handling out of the box to use of xmlhttprequest (which causes issues with bundling) - Twilio needs to get devs seriously involved with making the twilio-voice client useable because it'd be highly useful for lots of us if it worked but right now it's a burden to get up and running

@pgib
Copy link

pgib commented Feb 11, 2022

Yeah, went to import this package just now only to discover the latest release doesn't support anything other that node 12. Surprising to say the least!

@jonrose-dev
Copy link

Node 12 is entering End of Life in about 2 months. Requiring Node 12 makes using this a non-starter. Are there any timelines in place for when we can expect an update?

@pgib
Copy link

pgib commented Feb 18, 2022

Node 12 is entering End of Life in about 2 months. Requiring Node 12 makes using this a non-starter. Are there any timelines in place for when we can expect an update?

I'm using the Github repo as my package source in the meantime, and so far this is working okay. Would be good to have some official response though.

@jonrose-dev
Copy link

That's what we're looking into as well. It's a shame that this package is so far out of date

@charliesantos
Copy link
Collaborator

Hey everyone, apologies for the inconvenience. We are actively working on updating the codebase to make sure it's compatible with the latest tools. We have a few things in mind such as updating node version and some build tools. To help us address your concerns, can you please let us know what "modernize" mean from your perspective? We want to make sure our plan aligns with your expectations. Reading the comments here, I see the following:

  • support the latest node version
  • replacing xmlhttprequest with fetch - please let us know how this affects you
  • modernize codebase, with import, async - please let us know what this means to you
  • anything else?

As always, thank you for your contributions!

@charliesantos
Copy link
Collaborator

Hey everyone, we made a few improvements please check this out #55 (comment)
Other items mentioned in the previous comment will be addressed soon. Please stay tuned!

@manjeshbhargav manjeshbhargav self-assigned this Jun 7, 2023
@charliesantos
Copy link
Collaborator

We made more improvements and the SDK now supports most of the items mentioned in this ticket. Please see changelog for details. You can try these now in 2.6.0-rc2.

@charliesantos
Copy link
Collaborator

We just released 2.7.0 which supports ESM on certain frameworks. This is the last item that was needed to be addressed in this ticket. Thank you everyone for your contributions and please feel free to reach out again if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants