[BUG] _OnAnswer handler not being cleaned up in _cleanupEventListeners

[scottwthompson]

• [x ] I have verified that the issue occurs with the latest twilio.js release and is not marked as a known issue in the CHANGELOG.md.
• [ x] I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
• [ x] I verified that the Quickstart application works in my environment.
• [ x] I am not sharing any Personally Identifiable Information (PII)
  or sensitive account information (API keys, credentials, etc.) when reporting this issue.

_OnAnswer handler not being cleaned up in _cleanupEventListeners

Noticed in my logs

I think this PR here: #42 introduced the regression where your rebinding _onAnswer on every accept call but the this._pstream.removeListener('answer', this._onAnswer) call is now unsuccessful.

[bradleyy1012]

Same, glad to see I wasn't the only one with this issue.

[awwsnappitsrob24]

Does anyone have any updates on this?

[amrictor]

Waiting eagerly for a fix on this!

[bradleyy1012]

I'm not sure if this will cause any unexpected side effects, but could this be the solution?

[katie-bowman]

I have also experienced this bug, is there any update on this issue?

[mhuynh5757]

Hi all, thanks for bringing this one to the team's attention. We have filed an internal ticket to track this.

[kamalbennani]

Hi @mhuynh5757 the fix should be very straightforward here by just turning the _onAsnwer instance method to an arrow function, isn't it?
Do you want me to pull up a PR for it?

[mhuynh5757]

Hi @kamalbennani, thanks for the solution, but unfortunately that might not work due to the possibility of multiple answer events since we now have call reconnection logic, and using an arrow function means we won't be able to unbind properly.

[kamalbennani]

I misread the situation then 🤔

[charliesantos]

@bradleyy1012 's suggestion is correct. We will include the fix for this as part of #145

[bradleyy1012]

@bradleyy1012 's suggestion is correct. We will include the fix for this as part of #145

Great to hear, thank you! Credit goes to @amrictor.

[charliesantos]

Should be fixed in 2.4.0