Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VBLOCKS-330] Listen for multiple answer events. #42

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Conversation

mhuynh5757
Copy link
Collaborator

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR enables the SDK to listen for multiple answer events from the Twilio backend. This resolves some signaling reconnection issues.

Burndown

Before review

  • Updated CHANGELOG.md if necessary
  • Added unit tests if necessary
  • Updated affected documentation
  • Verified locally with npm test
  • Manually sanity tested running locally
  • Ready for review

Before merge

  • Got one or more +1s
  • Squashed erroneous commits if necessary
  • Re-tested if necessary

@charliesantos
Copy link
Collaborator

Code looks good. Should we add integration tests?

@mhuynh5757
Copy link
Collaborator Author

Code looks good. Should we add integration tests?

Whoops, I added the network/integration tests to the other PR #41, I'll pick them and add them here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants