Update mediaHandler.onopen to use mediaHandler.isMuted to mute/unmute

[zyzmoz]

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

• I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

Updated mediaHandler.onopen to use its isMuted property when muting/unmuting the call

Description

It is possible to mute/unmute the call prior to the media opening, causing divergence between the actions performed (mute/unmute) and the actual state (which would be always unmuted)

Burndown

Before review

• Added unit tests if necessary
• Verified locally with npm test
• Ready for review

Before merge

• Got one or more +1s
• Squashed erroneous commits if necessary
• Re-tested if necessary

[charliesantos]

@zyzmoz thank you for submitting this PR. Can you please provide more details regarding the issue this PR is trying to solve? Such as steps to reproduce, expected and actual behavior.

[zyzmoz]

So, when you make a call, you can mute or unmute that before the call is answered. If that call is muted and the other end answers, then the call will be unmuted by default. The changes I made solved that issue by using the mediaHandler state to mute/unmute the call when mediaHandler.onopen is triggered. Also, as the mediaHandler.isMuted default is false, the previous behaviour should be covered.

Steps to reproduce

1. Make a call
2. Mute on the Caller end without answering the call
3. Callee answers the call

Result: Call gets unmuted

[charliesantos]

@zyzmoz I included your changes into this PR #227 along with other changes. Thank you for your contribution!