VBLOCKS-2473 fix logLevel param to accept strings

[charliesantos]

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

• I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

VBLOCKS-2473

Burndown

Before review

• Updated CHANGELOG.md if necessary
• Added unit tests if necessary
• Updated affected documentation
• Verified locally with npm test
• Manually sanity tested running locally
• Ready for review

Before merge

• Got one or more +1s
• Squashed erroneous commits if necessary
• Re-tested if necessary

[mhuynh5757]

If I recall correctly, the same strings in all-caps are also valid in the logLevel library.

[charliesantos]

I checked the types and only numbers and lower case strings are accepted

declare namespace log {
    /**
     * Log levels
     */
    interface LogLevel {
        TRACE: 0;
        DEBUG: 1;
        INFO: 2;
        WARN: 3;
        ERROR: 4;
        SILENT: 5;
    }

    /**
     * Possible log level numbers.
     */
    type LogLevelNumbers = LogLevel[keyof LogLevel];

    /**
     * Possible log level descriptors, may be string, lower or upper case, or number.
     */
    type LogLevelDesc = LogLevelNumbers
        | 'trace'
        | 'debug'
        | 'info'
        | 'warn'
        | 'error'
        | 'silent'
        | keyof LogLevel;

[mhuynh5757]

keyof LogLevel would include the all-caps variants of the strings.

[charliesantos]

Ah true! Let me update the doc