Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider device key '' when evaluating for 'default' device #239

Closed

Commits on Jan 26, 2024

  1. Consider device key '' when evaluating for 'default' device

    On Chrome, if no media device permissions are given, the devices are
    exposed with minimal info:
    ```
    [
      {deviceId:'',kind:'audioinput',label:'',groupId:''},
      {deviceId:'',kind:'videoinput',label:'',groupId:''},
      {deviceId:'',kind:'audiooutput',label:'',groupId:''}
    ]
    ```
    
    After the media device permissions have been granted, a `devicechange`
    event is triggered and the previous device `''` is supposed to be
    removed but never is.
    
    This resulted in duplicate audio for users who are presented with
    the microphone permissions on their first call as the previous output
    device `''` never got properly removed.
    kmteras committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    86553b1 View commit details
    Browse the repository at this point in the history