Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLEXIN-212] - Now generating security headers #43

Merged
merged 4 commits into from
Aug 7, 2023
Merged

[FLEXIN-212] - Now generating security headers #43

merged 4 commits into from
Aug 7, 2023

Conversation

AnudeepChPaul
Copy link
Collaborator

Added:

  • Now generating security header for fingerprint generation
  • Now saving loginTimestamp to localStorage

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

ashishkumarTWLO
ashishkumarTWLO previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@ashishkumarTWLO ashishkumarTWLO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mdeshpande12
mdeshpande12 previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@mdeshpande12 mdeshpande12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mdeshpande12
mdeshpande12 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@mdeshpande12 mdeshpande12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AnudeepChPaul AnudeepChPaul merged commit de15cbc into flex-webchat-ui Aug 7, 2023
@AnudeepChPaul AnudeepChPaul deleted the FLEXIN-212 branch August 7, 2023 05:32
AnudeepChPaul added a commit that referenced this pull request Aug 31, 2023
@AnudeepChPaul
[FLEXIN-212] - Now generating security headers (#43)
921a222 
[FLEXIN-212] - Now generating security headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdeshpande12 mdeshpande12 mdeshpande12 approved these changes

@ashishkumarTWLO ashishkumarTWLO ashishkumarTWLO approved these changes

@vinesh-kumar vinesh-kumar vinesh-kumar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnudeepChPaul @vinesh-kumar @ashishkumarTWLO @mdeshpande12