Moved out Migration guide and new feature sections #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocs files Small updates to titles and renamed 3.x to 3.0 in some cases
kbagchiGWC
reviewed
Apr 1, 2019
| @@ -0,0 +1,128 @@ | |||
| ## 2.x to 3.x Migration Guide | |||
There was a problem hiding this comment.
Case mismatch - in some places it's 3.x, in other places it is 3.X.
There was a problem hiding this comment.
In some cases 3.x made sense ie in the migration guide. In the new features, it's 3.0
There was a problem hiding this comment.
I think @kbagchiGWC is referring to 3.x (lowercase x) vs 3.X (uppercase). The casing is different in some places in the doc.
There was a problem hiding this comment.
Ohh ok got it. Ill update to lower case
aymenn
changed the title
aymenn
changed the title
idelgado
approved these changes
Apr 1, 2019
The "x" in "2.x" and "3.x" was inconsistent - in some cases lower case and in others upper case. This PR changes the "x" to lower case
aaalaniz
pushed a commit
that referenced
this pull request
Apr 26, 2019
* Use 3.0.0-preview1 (#192) * Use 3.0.0-preview2 (#193) * Use preview3. (#196) * Migration guide (#197) * Using 3.0.0-preview4. (#205) Use preview4 * Use preview5. (#206) * Updated README migration section with custom parameters support entries. (#207) * New Features section (#212) * Describe handleMessage callback behavior differences between 2.X and 3.X (#216) * Use preview6. (#218) * Implement hold functionality (#220) * Use 3.0.0-beta1 (#223) * Use Voice SDK 3.0.0-beta2 (#228) * Task/update proguard rules (#229) * Add push credential docs (#232) * Use absolute URL so the Getting Started page resolves images (#236) * Removed extra space (#238) * Use Voice SDK 3.0.0-beta3 (#240) * Use beta4 (#243) * Update to 3.0.0-beta5 (#245) * Consume Android Voice SDK 3.0.0-beta6 (#250) Consume Android Voice SDK 3.0.0-beta6 * Use Voice Android SDK 3.0.0-beta7 (#252) * Use Voice Android SDK 3.0.0-beta8 (#255) * Moved out Migration guide and new feature sections (#257) * Moved out new features and migration guide sections and created new Docs files Small updates to titles and renamed 3.x to 3.0 in some cases * Made the "x" in "2.x" and "3.x" lower case The "x" in "2.x" and "3.x" was inconsistent - in some cases lower case and in others upper case. This commit changes the "X" to lower case * Use Voice Android SDK 3.0.0-beta9 (#258) * Use Voice Android SDK 3.0.0-beta10 (#259) * Improve param docs (#261) * Readme update with audio settings guidance (#260) * Use Voice Android SDK 3.0.0-beta10 * Updated README with troubleshooting audio section. Upadted VoiceActivity - requestAudioFocus now takes AudioManager.OnAudioFocusChangeListener instead of null listener. * Use Voice Android SDK 3.0.0-beta11 (#262) * Use Voice SDK 3.0.0_beta12 (#264) * Use Voice SDK 3.0.0_beta13 (#265) * Use Voice Android SDK 3.0.0 GA version (#266)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting started contained a section for Getting Started and a Section for Migration guide.
This pull request moved those sections (almost) verbatim to new corresponding files.
The changes to the actual content only contain title updates (to give context now that the section is in its own file) and for the new feature content, 3.x is now 3.0
Contributing to Twilio