Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VBLOCKS-3454] Quickstart Refactor #629

Merged
merged 20 commits into from
Jan 2, 2025
Merged

[VBLOCKS-3454] Quickstart Refactor #629

merged 20 commits into from
Jan 2, 2025

Conversation

afalls-twilio
Copy link
Contributor

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@afalls-twilio afalls-twilio marked this pull request as ready for review December 19, 2024 02:13
@ocarevs
Copy link
Collaborator

ocarevs commented Dec 19, 2024

Found two issues we might consider addressing with this PR.
Hold, mute and disconnect buttons disappear when screen is rotated. I believe this is the same case in the master branch.
Calling with dead token and immediately disconnecting, before UI updates because of Connect failure, app will crash with NullPointerException with this check here
Other than that LGTM.

@afalls-twilio
Copy link
Contributor Author

@ocarevs Thanks for finding those bugs, they should be fixed now, along with some other issues that were not reported.

@afalls-twilio afalls-twilio merged commit 142d1e5 into master Jan 2, 2025
3 checks passed
afalls-twilio added a commit that referenced this pull request Feb 1, 2025
@afalls-twilio
[VBLOCKS-3454] Quickstart Refactor (#629)
ec21a63 
* Refactored quickstart to simplify
   - Now target is API 34
   - Simplified incomming call notification flow
       * removed proxy activity
   - Voice service is foregrounded only durring actual call
       * No longer does the Voice Service attempt to foreground when activity is in background
            - No more exception on newer API versions for accessing the Microphone from the background
   - One centeral service for handling all voice actions
   - Added notification for when a call is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocarevs ocarevs ocarevs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afalls-twilio @ocarevs