Helper method for java root logger

[dentarg]

The variable confused me a bit.

[walro]

I skipped one-lining so I could give it a descriptive name. Logger.get_logger("") makes me wonder, what the heck does that return? By binding it to a variable I understand that it returns the root_logger object.

[walro]

What confused you btw? :)

[dentarg]

We change some global state, with the set_level call, and I thought it was easy to interpret it as we change only change it for our root_logger variable... and then we don't use it anywhere.

[dentarg]

By binding it to a variable I understand that it returns the root_logger object.

I don't know what a root_logger object so it didn't help me :-)

The better solution is probably to extract the code to a well named method in spec_helper?

[walro]

Yeah, wrapping it up in a method would improve it a bit. But I don't agree with your initial change.

Just because you don't know what something is does not mean that you should remove them.

See https://docs.oracle.com/javase/7/docs/api/java/util/logging/LogManager.html for reference (search for root)

[dentarg]

@walro WDYT?

[walro]

hihi now you can oneline since you have descriptive method name :D

[dentarg]

I like the comment and with this it's slightly more clear where it applies :)

[walro]

👍

[walro]

Maybe we should leave Level here, since we use it below. Suppose it's implicity added by the spec_helper now

[dentarg]

Yes, all specs use spec_helper, so I don't think it's needed, we will just be repeating ourselves