Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessor methods for connect_timeout and heartbeat_interval #28

Merged

Conversation

roback
Copy link
Member

@roback roback commented May 3, 2018

roback added 2 commits May 3, 2018 16:35
BinaryLogClient::keepAliveConnectTimeout has been deprecated and will
be removed in v1.0 of mysql-binlog-connector.
See shyiko/mysql-binlog-connector-java@0.8.1...0.9.0

Ecco::Client {get,set}_keep_alive_connect_timeout methods uses
{get,set}_connect_timeout, just as mysql-binlog-connector has
implemented it on their end.
Copy link
Contributor

@walro walro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roback roback merged commit e0ab70a into issue/18/update-mysql-binlog-connector May 4, 2018
@roback roback deleted the pr/27/add-accessor-methods branch May 4, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants