Replace Vagrant with Docker (Compose) #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Vagrant box we used is outdated. Also, I'd argue that docker is a tad easier to maintain. Close #39
|
(Test failures obviously unrelated) Edit: Addressed in e0808b6 |
... to get green builds. Xenial, and newer environments, only have MySQL 5.7. I think we should move towards 5.7 support: #41
walro
commented
Sep 6, 2019
`mysql_native_password` is already the default for MySQL 5.6
dentarg
approved these changes
Sep 9, 2019
|
Ran |
|
Use Docker at Travis? |
|
Ah, maybe out of scope for this PR :-) |
Yeah, think so. But good idea, I'll look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vagrant box we used is outdated. Also, I'd argue that docker is a tad easier to maintain.
Close #39