Use newer version of mysql-binlog-connector-java

[Chrizpy]

Close #49

The original author is no longer maintaining the one we are using.

[walro]

I was intrigued by the fact that the fork was 6 commits after "upstream", here's the missing stuff:

osheroff/mysql-binlog-connector-java@master...shyiko:master

Wonder if those things have been solved 🤔

Edit: osheroff/mysql-binlog-connector-java@master...shyiko:c54b4c1 these are the "relevant" changes between the two repos

[walro]

Wonder if those things have been solved 🤔

As far as I can tell, out of the 6 commits, only 3 of them changes anything substantial, these are:

• shyiko/mysql-binlog-connector-java@e59006e
• shyiko/mysql-binlog-connector-java@c54b4c1
• shyiko/mysql-binlog-connector-java@5dde1e6

The last one of these was fixed in the fork too by osheroff/mysql-binlog-connector-java@88de1ed

However, I don't see the other two being addressed in the fork. They both seem to be a part of solving shyiko/mysql-binlog-connector-java#321

Not sure if that's an issue for us, but we could see if the fork could pull those changes in for some peace of mind.

Edit: A bit shorter diff version for the stuff that matters: osheroff/mysql-binlog-connector-java@master...shyiko:c54b4c1

[Chrizpy]

I was intrigued by the fact that the fork was 6 commits after "upstream", here's the missing stuff:

osheroff/mysql-binlog-connector-java@master...shyiko:master

Wonder if those things have been solved 🤔

I was really confused by this comment for a while, I thought you meant that the fork was 6 ahead of the latest commit on "upstream". But you probably meant that it is 6 commits behind 😄 .

That makes a lot more sense. Seeing as we need (osheroff/mysql-binlog-connector-java@a6a3af7) for the last test case in #53 to become green, supposedly. Should we switch back to using the old repository then and wait on this fork to progress?

[walro]

But you probably meant that it is 6 commits behind

Yes, I should have typed "behind" instead of "after" :)

[walro]

Should we switch back to using the old repository then and wait on this fork to progress?

Not sure, we need to switch sooner or later. What I was thinking is that we could submit a PR (if it's resonable) with the fix that's missing in the fork.

[walro]

Since we don't use keepAlive in our "Ecco clients", I am pretty sure that we won't be affected by shyiko/mysql-binlog-connector-java#321. However, as we allow other users of Ecco to use keepAlive, I believe it would be cool if we could get the changes merged into the forked repo.

I will see what can be done, for now I believe we can merge this just to get MySQL 8.0 support going.

[walro]

See comment in #52 (comment)

[Chrizpy]

Closing this issue: #41 since this PR adds MySQL 8.0 support.

[Chrizpy]

Sprint86: Förbered Ecco för MySQL 5.7/8.0