Make sure row_event happens before save_event #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,9 @@ def self.wait_for_row_events(ecco_client, count: 1, &block) | |||
| end | |||
|
|
|||
| def self.wait_for_save_position_events(ecco_client, count: 1, &block) | |||
| # Take into account the initial save event that is emitted when client starts | |||
| count += 1 | |||
There was a problem hiding this comment.
What happens if I call this method twice in the same test? Won't it "overstep"?
There was a problem hiding this comment.
Nope, the client is started and stopped each time you call the method.
There was a problem hiding this comment.
Ok! Because we start and stop here, got it.
|
Left a comment concerning a comment, otherwise it looks good! |
|
LGTM, I think we can release as |
|
|
roback
added a commit
that referenced
this pull request
Nov 19, 2015
Make sure row_event happens before save_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5