fix(Model): fromArray 包含虚拟字段触发 Invalid virtual column: 错误

twinh · Nov 22, 2022 · f38dc31 · f38dc31
1 parent ad41224
commit f38dc31
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/lib/ModelTrait.php b/lib/ModelTrait.php
@@ -647,7 +647,7 @@ protected function fromArray(iterable $array): self
             }
 
             if ($this->hasVirtual($name)) {
-                $this->setVirtualValue($name, $value);
+                $this->callSetter($name, $value);
             }
         }
         return $this;

diff --git a/tests/unit/Model/Fixture/TestVirtual.php b/tests/unit/Model/Fixture/TestVirtual.php
@@ -23,6 +23,7 @@ class TestVirtual extends BaseModel
     protected $virtual = [
         'virtual_column',
         'full_name',
+        'only_get',
     ];
 
     protected $virtualColumnValue;
@@ -51,4 +52,9 @@ public function setFullNameAttribute($fullName)
     {
         [$this->first_name, $this->last_name] = explode(' ', $fullName);
     }
+
+    public function getOnlyGetAttribute()
+    {
+        return 'test';
+    }
 }
diff --git a/tests/unit/Model/VirtualTest.php b/tests/unit/Model/VirtualTest.php
@@ -118,4 +118,15 @@ public function testSetCamelCaseThrowsException()
         // @phpstan-ignore-next-line
         $virtual->virtualColumn = 'abc';
     }
+
+    public function testMissingSetVirtualAttributeMethod()
+    {
+        $virtual = TestVirtual::new();
+
+        $virtual->fromArray([
+            'only_get' => 'test2',
+        ]);
+
+        $this->assertSame('test', $virtual->get('only_get'));
+    }
 }