Dockerize #211

useffc · 2018-10-27T02:22:57Z

Forum seems to be functional.

Hot reloading works

Other Notes

Login, signup, create thread, post to thread flows work but I don't have explicit proof of those.

for web takes precedence over the CMD block of the Dockerfile

added and read which helps the database get initialized. Should have been between dee8b43 & 4885ab1

nchase · 2018-10-29T05:19:47Z

👏 👏 👏

I think the bugs you called out with posts in a thread being duplicated are bugs that currently exist regardless of containerized or not, we just don't see them because all of our threads have tons of posts.

useffc · 2018-10-29T11:23:13Z

disregard the assigning and un-assigning, i'm just click-happy

db host in tests

useffc · 2018-10-29T22:50:03Z

46b88d6 gets tests passing or pending, but I'm a bit concerned about those timeouts.

container (still no hot reload)

docker-compose.yml

nchase

👍👍

…as, killed light atom borders

useffc added 2 commits October 26, 2018 22:19

initial work on Dockerizing forum app

4885ab1

seems to be working now. apparently the command part of docker-compose

dee8b43

for web takes precedence over the CMD block of the Dockerfile

useffc assigned nchase Oct 29, 2018

useffc added 2 commits October 28, 2018 22:21

Add Dockerfile for postgres; seems to allow tables.sql to be correctly

5384d52

added and read which helps the database get initialized. Should have been between dee8b43 & 4885ab1

clean up comments

2df7913

useffc force-pushed the dockerize branch from 4205e3c to 2df7913 Compare October 29, 2018 02:22

try to get travis to run tests

491daf0

useffc unassigned nchase Oct 29, 2018

make test db (with own dockerfile) and test service. point urls to test

46b88d6

db host in tests

useffc added 2 commits October 29, 2018 19:12

map local volumes to container volumes so changes will come through to

f60a315

container (still no hot reload)

update docs a bit to mirror how this is currently working

de30588

useffc mentioned this pull request Oct 30, 2018

Dark theme #212

Merged

nchase reviewed Oct 30, 2018

View reviewed changes

docker-compose.yml Show resolved Hide resolved

nchase reviewed Oct 30, 2018

View reviewed changes

docker-compose.yml Outdated Show resolved Hide resolved

update test service name from e2e

476008d

useffc force-pushed the dockerize branch from f383020 to 476008d Compare October 31, 2018 00:45

useffc added 2 commits October 31, 2018 21:06

hot reloading works with docker

8442772

update docs on hot reloading

c53f5bd

nchase reviewed Nov 1, 2018

View reviewed changes

nchase and others added 8 commits December 26, 2018 15:14

use node 8 in docker, kill unused node8-incompatible dependency

0db8d40

use nodemon to run dev server, expose all at /code in container

04254a4

add dockerignore to keep node_modules from being copied to container

03a41fe

update signup token

b97e6f9

kill dumb redirect code

00f7be4

Merge branch 'dockerize-plus-server-reload' into dockerize

5251b20

noodling with dark theme

d9567f9

move style choice outside of react to avoid flash of mis-styled content

b130abc

add a couple of additional dark styles (loading, a couple of text are…

372bcbe

…as, killed light atom borders

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dockerize #211

Dockerize #211

useffc commented Oct 27, 2018 •

edited

Loading

Uh oh!

nchase commented Oct 29, 2018

Uh oh!

useffc commented Oct 29, 2018

Uh oh!

useffc commented Oct 29, 2018

Uh oh!

Uh oh!

Uh oh!

nchase left a comment

Uh oh!

Dockerize #211

Are you sure you want to change the base?

Dockerize #211

Conversation

useffc commented Oct 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other Notes

Uh oh!

nchase commented Oct 29, 2018

Uh oh!

useffc commented Oct 29, 2018

Uh oh!

useffc commented Oct 29, 2018

Uh oh!

Uh oh!

Uh oh!

nchase left a comment

Choose a reason for hiding this comment

Uh oh!

useffc commented Oct 27, 2018 •

edited

Loading