PyPI trusted publishing #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twm
force-pushed
the
trusted-publishing
branch
4 times, most recently
from
8695446 to
24fc0c9
Compare
This allows ripgrep to search within it.
twm
force-pushed
the
trusted-publishing
branch
2 times, most recently
from
ec971f5 to
bc56fc5
Compare
`python -m build` doesn't successfully build with the previous hack because the setuptools entry points aren't installed. (I am not sure how it ever worked under tox-wheel — a pre-existing install of incremental?) So we synthesize the entry points in _build_meta.py. Is this better than the original hack? 🤷
glyph
reviewed
Jul 22, 2024
twm
commented
Jul 23, 2024
adiroiban
approved these changes
Jul 24, 2024
|
Thank you for the review @adiroiban! I'll issue a release now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup GHA to release to PyPI via trusted publisher.
On PR: Build the package using
python -m buildand chain it into the tests.On tag push: build the package and publish to PyPI.
I have created a trusted publisher on PyPI for Incremental. Hopefully this works 🤞 — we'll see when we hit release candidate. I plan to burn through some more tickets first.