Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeErrors in MatchMixin #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix TypeErrors in MatchMixin #244

wants to merge 1 commit into from

Conversation

jemrobinson
Copy link

Contributor Checklist:

  • I have updated the release notes at docs/source/NEWS.rst
  • I have updated the automated tests.
  • All tests pass on your local dev environment. See CONTRIBUTING.rst.

Summary

When MatchMixin makes calls to str.startswith, str.endswith and str.find, the argument is currently a bytes not a str. This causes a crash, which can most easily be seen when using a wildcard search filter.

decode()ing the bytes to a str fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jemrobinson