-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title_format tests and drop a line #299
Merged
altendky
merged 13 commits into
twisted:master
from
altendky:title_format_tests_and_tweak
Dec 20, 2020
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1cf7dca
Add title_format tests and drop a line
altendky 83f52f1
flake8
altendky bc2747a
Add 299.misc.rst
altendky 06b3e91
Add test docstrings
altendky c814f87
Merge branch 'master' into title_format_tests_and_tweak
altendky 057094e
update test
altendky 51a35d3
Update test_build.py
altendky 03c4731
Update test_build.py
altendky 57321b2
remove whitespace from a blank line
altendky c1a1570
Apply suggestions from code review
altendky ea201f1
fixup
altendky 0fdef36
expound case in test docstring
altendky fd541c7
add brief explanation of title_format outside the example
altendky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this when reporting the fix worked for me... This is well incorrect, the title should not appear here as per
title_format = false
above?