Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove own usage of incremental. #398

Closed
wants to merge 3 commits into from
Closed

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Jul 16, 2022

Description

Fixes #308

To simplify the number of dependencies towncrier can use a string as its version.

Also, when finding the version of a project, just use str() on the project version instancce.

project using incremental are still supported, as str(incremental.Version) does not return what we want... and is ok to keep incrementla for backwards compatibility.

Todo

See if version is a tuple and join them with a dot.
For anything else, just call str(version_object) and strip it.

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

@adiroiban adiroiban marked this pull request as draft July 17, 2022 11:39
@hynek
Copy link
Member

hynek commented Aug 31, 2022

Do you still want to do this Adi? Or wanna start fresh? (I support the change, but this branch is very stale)

@adiroiban
Copy link
Member Author

I still would like to have a simple string as the version for towncrier.
Right now, I don't have the motivation and time to continue the work.

@SmileyChris SmileyChris mentioned this pull request Mar 27, 2023
7 tasks
@adiroiban
Copy link
Member Author

This can be closed as there is #491

@adiroiban adiroiban closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on incremental in favor of general compatible solution
2 participants