Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 #521

Merged
merged 2 commits into from
Jun 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,6 @@ jobs:
fail-fast: false
matrix:
python:
- name: CPython 3.7
action: 3.7
- name: CPython 3.8
action: 3.8
- name: CPython 3.9
Expand All @@ -70,8 +68,6 @@ jobs:
action: '3.10'
- name: CPython 3.11
action: '3.11'
- name: PyPy 3.7
action: pypy3.7
- name: PyPy 3.8
action: pypy3.8
task:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ repos:
rev: v3.4.0
hooks:
- id: pyupgrade
args: [--py37-plus]
args: [--py38-plus]

- repo: https://github.com/PyCQA/isort
rev: 5.12.0
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Rather than reading the Git history, or having one single file which developers

Used by `Twisted <https://github.com/twisted/twisted>`_, `pytest <https://github.com/pytest-dev/pytest/>`_, `pip <https://github.com/pypa/pip/>`_, `BuildBot <https://github.com/buildbot/buildbot>`_, and `attrs <https://github.com/python-attrs/attrs>`_, among others.

While the command line tool ``towncrier`` works on Python 3.7+ only, as long as you don't use any Python-specific affordances (like auto-detection of the project version), it is usable with **any project type** on **any platform**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the range of supported versions not of interest any more?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's plenty of other places to look it up that have to be kept up to date and i'm gonna claim it's just confusing & useless for users who just check out the readme

While the command line tool ``towncrier`` requires Python to run, as long as you don't use any Python-specific affordances (like auto-detection of the project version), it is usable with **any project type** on **any platform**.


Philosophy
Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def pre_commit(session: nox.Session) -> None:
session.run("pre-commit", "run", "--all-files", "--show-diff-on-failure")


@nox.session(python=["pypy3.7", "pypy3.8", "3.7", "3.8", "3.9", "3.10", "3.11"])
@nox.session(python=["pypy3.8", "3.8", "3.9", "3.10", "3.11"])
def tests(session: nox.Session) -> None:
session.install("Twisted", "coverage[toml]")
posargs = list(session.posargs)
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,14 @@ classifiers = [
"Operating System :: POSIX :: Linux",
"Operating System :: MacOS :: MacOS X",
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: Implementation :: CPython",
"Programming Language :: Python :: Implementation :: PyPy",
]
requires-python = ">=3.7"
requires-python = ">=3.8"
dependencies = [
"click",
"click-default-group",
Expand Down
10 changes: 1 addition & 9 deletions src/towncrier/_settings/load.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,13 @@

from contextlib import ExitStack
from pathlib import Path
from typing import TYPE_CHECKING, Any, Mapping, Sequence
from typing import Any, Literal, Mapping, Sequence

from click import ClickException

from .._settings import fragment_types as ft


if TYPE_CHECKING:
# We only use Literal for type-checking and Mypy always brings its own
# typing_extensions so this is safe without further dependencies.
if sys.version_info < (3, 8):
from typing_extensions import Literal
else:
from typing import Literal

if sys.version_info < (3, 10):
import importlib_resources as resources
else:
Expand Down
1 change: 1 addition & 0 deletions src/towncrier/newsfragments/521.removal
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
The support for Python 3.7 has been dropped.