Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace between releases can be configured in the template. #553

Merged
merged 6 commits into from
Oct 21, 2023

Conversation

iliakur
Copy link
Contributor

@iliakur iliakur commented Oct 19, 2023

It used to be baked into the rendering code.

Description

Implementation of #552

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).
  • Ensure docs/tutorial.rst is still up-to-date.
  • If you add new CLI arguments (or change the meaning of existing ones), make sure docs/cli.rst reflects those changes.
  • If you add new configuration options (or change the meaning of existing ones), make sure docs/configuration.rst reflects those changes.

@iliakur iliakur requested a review from a team as a code owner October 19, 2023 22:15
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

Changes looks good.

I left a few minor comments.


A note for another PR

I now see that we don't run towncrier draft as part of the CI process.

I guess that it could help to have it executed and the output sent as part of the job output...

similar to the output that we have for build and coverage

https://github.com/twisted/towncrier/actions/runs/6580860357#summar

src/towncrier/_writer.py Show resolved Hide resolved
src/towncrier/build.py Outdated Show resolved Hide resolved
src/towncrier/newsfragments/552.feature Outdated Show resolved Hide resolved
src/towncrier/templates/default.md Outdated Show resolved Hide resolved
@iliakur
Copy link
Contributor Author

iliakur commented Oct 20, 2023

@adiroiban this is ready for review, thanks!

@iliakur iliakur force-pushed the ik/all-whitespace-in-template branch from 443b0a3 to 07ca4f1 Compare October 20, 2023 23:49
@adiroiban
Copy link
Member

Thanks for the extra comment. Looks good. I will merge.

@adiroiban adiroiban merged commit 3f24b6e into twisted:trunk Oct 21, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants