-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitespace between releases can be configured in the template. #553
Whitespace between releases can be configured in the template. #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
Changes looks good.
I left a few minor comments.
A note for another PR
I now see that we don't run towncrier draft
as part of the CI process.
I guess that it could help to have it executed and the output sent as part of the job output...
similar to the output that we have for build and coverage
https://github.com/twisted/towncrier/actions/runs/6580860357#summar
@adiroiban this is ready for review, thanks! |
It used to be baked into the rendering code.
for more information, see https://pre-commit.ci
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
443b0a3
to
07ca4f1
Compare
Thanks for the extra comment. Looks good. I will merge. |
It used to be baked into the rendering code.
Description
Implementation of #552
Checklist
src/towncrier/newsfragments/
. Describe yourchange and include important information. Your change will be included in the public release notes.
docs/tutorial.rst
is still up-to-date.docs/cli.rst
reflects those changes.docs/configuration.rst
reflects those changes.