automatically ignore template files #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if I should create a changelog that is |
for more information, see https://pre-commit.ci
adiroiban
requested changes
Jul 31, 2024
adiroiban
requested changes
Jul 31, 2024
adiroiban
reviewed
Jul 31, 2024
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
adiroiban
reviewed
Jul 31, 2024
|
The documentation also needs to be updated.
Maybe something like this -Some filenames such as .gitignore and README are automatically ignored. However, if a custom template is stored in the news fragment directory, you should add it to this list.
+Some filenames such as .gitignore, README.rst. README.md, and the template file, are automatically ignored. |
Co-authored-by: Adi Roiban <adiroiban@gmail.com>
adiroiban
approved these changes
Jul 31, 2024
adiroiban
reviewed
Jul 31, 2024
adiroiban
reviewed
Jul 31, 2024
|
Sorry for the mess. I will try to get this this merged and then look at doing a new release. |
adiroiban
reviewed
Jul 31, 2024
| # Template can be a tuple of (package_name, resource_name). | ||
| # | ||
| # See https://github.com/twisted/towncrier/issues/634 | ||
| ignored_files.add(config.template) |
There was a problem hiding this comment.
This is not ok.
We should extract the filename from the filepath.
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically ignore template files
Closes #632