Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.4 #241

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Drop support for Python 3.4 #241

merged 1 commit into from
Apr 24, 2019

Conversation

twm
Copy link
Contributor

@twm twm commented Apr 22, 2019

Closes #240.

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          26       26           
  Lines        2285     2285           
  Branches      165      165           
=======================================
  Hits         2259     2259           
  Misses         14       14           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed0d46...8241019. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 22, 2019 •
edited
Loading

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #241   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files          26       26           
  Lines        2285     2285           
  Branches      165      165           
=======================================
  Hits         2259     2259           
  Misses         14       14           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed0d46...8241019. Read the comment docs.

@twm twm requested a review from a team April 22, 2019 06:27
adiroiban
adiroiban approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks :)

I am looking at #169 and I don't understand why this is needed

@twm
Copy link
Contributor Author

twm commented Apr 24, 2019

Thanks for the review, @adiroiban!

@twm twm merged commit eeb4d62 into twisted:master Apr 24, 2019
@twm twm deleted the bye-3.4 branch April 24, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.4
2 participants
@twm @adiroiban