Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PEP 517 / PEP 518 metadata #329

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Add PEP 517 / PEP 518 metadata #329

merged 2 commits into from
Apr 21, 2021

Conversation

twm
Copy link
Contributor

@twm twm commented Apr 18, 2021

This moves the build-time dependency on incremental to a declarativefile. See 1 for background.

twm added 2 commits April 17, 2021 18:27
@twm
Add PEP 517 / PEP 518 metadata
129ab7c 
This moves the build-time dependency on incremental to a declarative
file. See [1] for background.

[1]: https://twistedmatrix.com/trac/ticket/9457
@twm
Add change fragment
138da36
@twm twm requested a review from a team April 18, 2021 02:28
adiroiban
adiroiban approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. All good.
The coveralls errors can be ignored.

@twm
Copy link
Contributor Author

twm commented Apr 21, 2021

Thank you for the review @adiroiban!

@twm twm merged commit 4be2f69 into twisted:master Apr 21, 2021
@twm twm deleted the pyproject-toml branch April 21, 2021 04:12
@twm twm added this to the Treq 21.5.0 milestone May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
treq 21.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@twm @adiroiban